_utils: Make sure boto3's default session is used #245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@igorborgest I am not sure how would one test something like this but I'd be happy to incorporate some tests, if that was advisable. Furthermore, if this ever makes it to Please do let me know if there is anything you'd like me to update here. Thanks! |
* Currently `awswrangler` ensures that at least some boto3 Session is used when it calls AWS resources. However, since it creates a `boto3.Session()` when non-null boto3 Session is passed as a parameter, it completely sidesteps the ability of the user to set parameters to the boto3 session that gets used by default (via the `boto3.setup_default_session` function). * This commit ensures that the `ensure_session` function uses boto3's default session (reachable via `boto3._get_default_session()`) which then also allows `awswrangler` users to set default parameters of the boto3 Session it uses by default via `boto3.setup_default_session()`. Signed-off-by: mr.Shu <mr@shu.io>
mrshu
force-pushed
the
mrshu/use-boto3-default-session
branch
from
1eea0ee to
c8ea710
Compare
Contributor
|
Hi @mrshu, thanks for the contribution. It makes a lot of sense. I would like to avoid access to external private methods as much as possible, but I can't see an alternative by now. I will merge it on the dev branch and then write some tests to cover it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Currently
awswranglerensures that at least some boto3 Session isused when it calls AWS resources. However, since it creates a
boto3.Session()when non-null boto3 Session is passed as aparameter, it completely sidesteps the ability of the user to set
parameters to the boto3 session that gets used by default (via the
boto3.setup_default_sessionfunction).This commit ensures that the
ensure_sessionfunction uses boto3'sdefault session (reachable via
boto3._get_default_session()) whichthen also allows
awswranglerusers to set default parameters of theboto3 Session it uses by default via
boto3.setup_default_session().Signed-off-by: mr.Shu mr@shu.io
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Relevant link: https://boto3.amazonaws.com/v1/documentation/api/latest/_modules/boto3.html#setup_default_session